fix: removed add button from SpAppResource table
#7684
Conversation
|
As an aside, I have a comment about a couple minor UI bugs regarding the save button within collection preferences depending on where it's accessed. For example, going through the route of User Tools --> App Resources --> Collection Preferences, the save button begins as grayed out. After making edits but then returning to default state, it reappears as its beginning grayed out state. It makes more sense to have this be a functional close button. Screen.Recording.2026-02-04.at.3.02.58.PM.movGoing straight to User Tools --> Collection Preferences, there is a functional close button as default. This makes sense! However, if I alter the page by selecting and unselecting options, I can never return to the beginning state close button its manipulated back to its default state. Screen.Recording.2026-02-04.at.3.04.25.PM.mov |
emenslin
left a comment
emenslin
left a comment
There was a problem hiding this comment.
- Go to app resources, click on collection preferences, and verify that the add button is absent
Looks good! My only note is that this applies to all app resources not just collection preferences, this seems intentional based on what you said at the beginning of the PR; however, since the testing instructions only mention checking collection preferences I wanted to make note of it here.
Also just so you know I did look at your videos and I was not able to recreate the issue when going through app resources, and I honestly don't recall ever running into it (although I could be wrong) so there might be something else effecting that behavior.
02-09_11.19.mp4
2 participants
Fixes #4950
This fix removes the add button from the
SpAppResoucetable. In the UI, this is noticeable when you navigate to User Tools --> App Resources --> Collection Preferences. At the bottom right of the screen, only a save button appears now as the add button did not serve a necessary purpose. This is becauseSpAppResoucestores app resources like reports, labels, JSON configs, etc and such settings can be applied through the save button.The change comes by adding
SpAppResourceto theFORBID_ADDINGset inResourceView.tsx:specify7/specifyweb/frontend/js_src/lib/components/Forms/ResourceView.tsx
Lines 40 to 60 in d1f9f23
Checklist
self-explanatory (or properly documented)
Testing instructions